Skip to content
This repository has been archived by the owner. It is now read-only.

Fix zoom level on browser restore #7852

Closed
wants to merge 1 commit into from
Closed

Fix zoom level on browser restore #7852

wants to merge 1 commit into from

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Mar 23, 2017

and remove deprecated zoom level site setting.

fix #7832

Test Plan:

  1. launch clean instance of brave
  2. go to example.com and change the zoom level
  3. close brave
  4. reopen brave
  5. example.com should load with the previous zoom setting
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

and remove deprecated zoom level site setting.

fix #7832

Test Plan:
1. launch clean instance of brave
2. go to example.com and change the zoom level
3. close brave
4. reopen brave
5. example.com should load with the previous zoom setting
@diracdeltas diracdeltas added this to the 0.14.0 milestone Mar 23, 2017
@diracdeltas diracdeltas requested review from bridiver and luixxiul Mar 23, 2017
return
}
this.webview.removeEventListener(e.type, zoomCallback)
const zoomPercentage = this.frame && this.frame.get('lastZoomPercentage')

This comment has been minimized.

Copy link
@bridiver

bridiver Mar 23, 2017

Collaborator

muon should is supposed to handle this automatically so I think we should fix the problem there. If we need something on the browser-laptop side we should do it in tabs.js because all of the webview methods are deprecated (especially getter methods because they are sync ipc)

@diracdeltas
Copy link
Member Author

diracdeltas commented Mar 23, 2017

closing in favor of brave/muon@7baccbe

@luixxiul luixxiul removed this from the 0.14.0 milestone Mar 23, 2017
@luixxiul luixxiul removed their request for review Mar 23, 2017
@diracdeltas diracdeltas deleted the fix/zoom branch Mar 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.