This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix zoom level on browser restore #7852
Closed
Conversation
| return | ||
| } | ||
| this.webview.removeEventListener(e.type, zoomCallback) | ||
| const zoomPercentage = this.frame && this.frame.get('lastZoomPercentage') |
This comment has been minimized.
This comment has been minimized.
bridiver
Mar 23, 2017
Collaborator
muon should is supposed to handle this automatically so I think we should fix the problem there. If we need something on the browser-laptop side we should do it in tabs.js because all of the webview methods are deprecated (especially getter methods because they are sync ipc)
|
closing in favor of brave/muon@7baccbe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
diracdeltas commentedMar 23, 2017
•
edited
and remove deprecated zoom level site setting.
fix #7832
Test Plan:
git rebase -ito squash commits (if needed).Test Plan: