Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Adds lion badge #7861

Merged
merged 1 commit into from Mar 23, 2017
Merged

Adds lion badge #7861

merged 1 commit into from Mar 23, 2017

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Mar 23, 2017 •
edited

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7859

Auditors

@bradleyrichter @jonathansampson @bsclifton

Test Plan

  • go to youtube
  • play some videos
  • check if licon badge has the same number as shield panel
@NejcZdovc NejcZdovc added this to the 0.14.1 milestone Mar 23, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 23, 2017
@NejcZdovc
Adds lion badge
Unverified
This user has not uploaded their public key yet.
GPG key ID: 584931E990AC6064 Learn about signing commits
Loading status checks…
73fdd4c 
Resolves #7859

Auditors: @bradleyrichter @jonathansampson @bsclifton

Test Plan:
- go to youtube
- play some videos
- check if licon badge has the same number as shield panel
@NejcZdovc NejcZdovc force-pushed the NejcZdovc:feature/#7859-lion-badge branch from 9ce31e7 to 73fdd4c Mar 23, 2017
@bsclifton
bsclifton approved these changes Mar 23, 2017
View changes
Copy link
Member

bsclifton left a comment

Great job! 🦁 Big ++ for the test too
@bsclifton bsclifton merged commit 4cc431b into brave:master Mar 23, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bsclifton bsclifton modified the milestones: 0.14.0, 0.14.1 Mar 23, 2017
@jonathansampson

This comment has been minimized.

Sign in to view
Copy link
Collaborator

jonathansampson commented on js/components/main.js in 73fdd4c Mar 26, 2017 •
edited

frames may not be an immutable list, causing a getIn from undefined exception. Ran into this just now when firing-up Brave locally.

This comment has been minimized.

Sign in to view
Copy link
Member Author

NejcZdovc replied Mar 26, 2017

Will add check when doing this issue #7886
@jonathansampson

This comment has been minimized.

Sign in to view
Copy link
Collaborator

jonathansampson commented on js/components/main.js in 73fdd4c Mar 26, 2017 •
edited

frames may not be an immutable list, causing a getIn from undefined exception. Ran into this just now when firing-up Brave locally.

This comment has been minimized.

Sign in to view
Copy link
Member Author

NejcZdovc replied Mar 26, 2017

Will add check when doing this issue #7886
NejcZdovc added a commit that referenced this pull request Mar 26, 2017
@NejcZdovc
Fixes the crash on a fresh profile
Unverified
This user has not uploaded their public key yet.
GPG key ID: 584931E990AC6064 Learn about signing commits
Loading status checks…
9ef2665 
Issue was introduced with #7861

Auditors: @bsclifton @jonathansampson

Test Plan:
- start browser with a fresh profile
- there shouldn't be any erros or white screen
bsclifton added a commit that referenced this pull request Mar 26, 2017
@NejcZdovc @bsclifton
Fixes the crash on a fresh profile
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
c760a6a 
Issue was introduced with #7861

Auditors: @bsclifton @jonathansampson

Test Plan:
- start browser with a fresh profile
- there shouldn't be any erros or white screen
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

@jonathansampson jonathansampson

@bradleyrichter bradleyrichter

Assignees

@NejcZdovc NejcZdovc

Labels
feature/shields
Projects
None yet
Milestone
  0.14.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@NejcZdovc @bsclifton @jonathansampson @cndouglas
You can’t perform that action at this time.