Skip to content
This repository has been archived by the owner. It is now read-only.

show warning message and scary icon on data: urls #7865

Merged
merged 1 commit into from Mar 26, 2017
Merged

show warning message and scary icon on data: urls #7865

merged 1 commit into from Mar 26, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Mar 24, 2017

to prevent phishing attempts.
fix #4899

Test Plan:

  1. automated tests should pass
  2. enter data:text/html,hi in the urlbar
  3. you should see a popup warning you about phishing
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@diracdeltas diracdeltas added this to the 0.14.1 milestone Mar 24, 2017
@luixxiul luixxiul added the security label Mar 24, 2017
@diracdeltas diracdeltas requested a review from darkdh Mar 24, 2017
@diracdeltas diracdeltas self-assigned this Mar 24, 2017
to prevent phishing attempts.
fix #4899

Test Plan:
1. automated tests should pass
2. enter data:text/html,<body>hi</body> in the urlbar
3. you should see a popup warning you about phishing
@darkdh
darkdh approved these changes Mar 25, 2017
Copy link
Member

darkdh left a comment

lgtm

@diracdeltas diracdeltas merged commit 1465601 into master Mar 26, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@diracdeltas diracdeltas deleted the fix/4899 branch Mar 26, 2017
@darkdh darkdh modified the milestones: 0.14.0, 0.14.1 Mar 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.