This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHides lion badge when count is 0 #7877
Merged
Conversation
Resolves #7873 Auditors: @bsclifton @luixxiul Test Plan: - go to brave.com - badge should be hidden
|
LGTM |
|
Feedback left- maybe when looking at the fingerprinting, we can do the tests |
| @@ -886,7 +886,7 @@ class Main extends ImmutableComponent { | |||
| const trackers = frames.getIn(['trackingProtection', 'blocked']) | |||
| const blocked = (ads ? ads.size : 0) + (trackers ? trackers.size : 0) | |||
|
|
|||
| return (blocked > 99) ? '99+' : blocked | |||
| return (blocked.size === 0) ? false : ((blocked > 99) ? '99+' : blocked) | |||
This comment has been minimized.
This comment has been minimized.
bsclifton
Mar 25, 2017
Member
The change looks great. I think it could be better though if you pulled the logic out to a method and then had a unit test for it, using enzyme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NejcZdovc commentedMar 24, 2017
git rebase -ito squash commits (if needed).Resolves #7873
Auditors
@bsclifton @luixxiul
Test Plan