Show Locale Strings on Extensions Page

[jonathansampson]

Test Plan

1. Enable Dashlane
2. Navigate to about:extensions
3. Confirm that Dashlane's name and description are shown

Description

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

Fixes #7826 #7683

[cezaraugusto]

Looks good visually and works ok for some extensions but needs another check to avoid issues while toggling enabled/disabled extension state.

[cezaraugusto]

I think you need another check here. While toggling passwords I got the following error reported on console:

An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot read property '1' of null
    at properties.forEach (/Users/cezaraugusto/dev/browser-laptop/app/extensions.js:376:57)
    at Array.forEach (native)
    at insertLocaleStrings (/Users/cezaraugusto/dev/browser-laptop/app/extensions.js:375:20)
    at process.on (/Users/cezaraugusto/dev/browser-laptop/app/extensions.js:358:19)
    at emitOne (events.js:96:13)
    at process.emit (events.js:188:7)
    at process.on (/Users/cezaraugusto/dev/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/extensions.js:37:11)
    at emitOne (events.js:96:13)
    at process.emit (events.js:188:7)

[cezaraugusto]

fyi: log error happened while toggling last pass and pocket

[jonathansampson]

@cezaraugusto What do you mean by toggling? Were you enabling and disabling the extension(s) in Preferences?

Nevermind. I repro.

[bsclifton]

Tested it out, works perfectly! Great job on this one 😄

@cezaraugusto Sampson had updated after your feedback and I manually tested, looked great. Do you mind also confirming? (will merge here)