Skip to content
This repository has been archived by the owner. It is now read-only.

open background page devtools when navigating to background page url #7895

Merged
merged 1 commit into from Mar 26, 2017

Conversation

@bridiver
Copy link
Collaborator

bridiver commented Mar 25, 2017

fix #7880
requires brave/muon@42b9c96

note: url will not properly reset until #7894 is fixed

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Navigate to a background page url (chrome-extension://cjnmeadmgmiihncdidmfiabhenbggfjm/_generated_background_page.html)
  2. page should not navigate
  3. devtools should open for the background page
  4. click on the main window to put the devtools in the background
  5. navigate to the background page url again
  6. devtools should focus
  7. type console.log('test') in the devtools window
  8. close the devtools
  9. navigate to the background page again
  10. devtools should open and display the previous output from console.log('test')

cc @jonathansampson @bbondy - please note the muon requirement for this

@bridiver
Copy link
Collaborator Author

bridiver commented Mar 25, 2017

cc @ayumi @diracdeltas - this fixes the issue with opening multiple copies of the background pages

@bridiver bridiver force-pushed the background-devtools branch 2 times, most recently from 8527ae7 to 47793ab Mar 25, 2017
@bridiver bridiver force-pushed the background-devtools branch from 47793ab to 17b7cbe Mar 26, 2017
@bridiver bridiver merged commit d26f8cf into master Mar 26, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bridiver bridiver deleted the background-devtools branch Mar 26, 2017
@luixxiul luixxiul added this to the 0.14.1 milestone Mar 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.