Skip to content
This repository has been archived by the owner. It is now read-only.

Adds fingerprint and scripts to the lion badge count #7900

Merged
merged 2 commits into from Mar 27, 2017

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Mar 26, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #7886

Auditor

@bsclifton

Test Plan

  • Visit icloud.com with fingerprint enabled
  • badge count should be 1
Resolves #7886

Auditors: @bsclifton

Test Plan:
- Visit icloud.com with fingerprint enabled
- badge count should be 1
@NejcZdovc NejcZdovc added this to the 0.14.0 milestone Mar 26, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 26, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton Mar 26, 2017
…method

Auditors: @NejcZdovc
Copy link
Member

bsclifton left a comment

Added some unit tests 😄 Also manually tested, looks great ++

@bsclifton bsclifton merged commit 9058d8f into brave:master Mar 27, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@NejcZdovc

This comment has been minimized.

Copy link
Owner

NejcZdovc commented on 6092250 Mar 27, 2017

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.