Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate UI spec for private tabs #7944
Conversation
|
I added #547 as another issue to be closed with this PR. |
|
nice catch, thanks |
|
@bradleyrichter I personally prefer to have purple background all the time. This ways I can easily and more importantly faster see which tab is private. Other then that, this PR LGTM |
|
LGTM |
- Close #7943 - Auditors: @bsclifton
|
@NejcZdovc Did you also find that the colored non-selected private tab made it more difficult see which tab is selected? I think this problem is more severe than knowing if the tab is private before selection. But maybe I need to consider more use cases... |
|
@bradleyrichter you could create a follow up issue if it made sense- we could have logic which sets a light pastel purple when the private tab is not selected and the regular color purple when it is selected/active. I think this is a good compromise |
… of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg
* Followup on #7944, change inactive private tab background to 30% of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg * Update per feedback by @cezaraugusto Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. open private tab 2. open another private tab 3. non active private tab should have light purple background
* Followup on #7944, change inactive private tab background to 30% of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg * Update per feedback by @cezaraugusto Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. open private tab 2. open another private tab 3. non active private tab should have light purple background
* Followup on #7944, change inactive private tab background to 30% of original color Auditors: @bsclifton @cezaraugusto @bradleyrichter Test Plan: - open private tab - open another private tab - non active private tab should have light purple bg * Update per feedback by @cezaraugusto Auditors: @cezaraugusto, @NejcZdovc Test Plan: 1. open private tab 2. open another private tab 3. non active private tab should have light purple background
cezaraugusto commentedMar 29, 2017
•
edited by luixxiul
git rebase -ito squash commits (if needed).Close #7943
Close #547
Auditors: @bsclifton
Test Plan: