Skip to content
This repository has been archived by the owner. It is now read-only.

Build: Update babel env to chrome 57 #8047

Merged
merged 1 commit into from Apr 17, 2017
Merged

Build: Update babel env to chrome 57 #8047

merged 1 commit into from Apr 17, 2017

Conversation

@gyandeeps
Copy link
Contributor

gyandeeps commented Apr 2, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

It updates the babel env to chrome 57

Copy link
Contributor

cezaraugusto left a comment

LGTM

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Apr 16, 2017

@bsclifton do you think that can have any drawbacks while building?

@bbondy bbondy added this to the 0.15.1 milestone Apr 17, 2017
@bbondy
Copy link
Member

bbondy commented Apr 17, 2017

I think the unit tests look ok and it would land at the start of our 0.15.1 cycle so it's a good time to pull it in.

@bbondy bbondy merged commit 0dfd168 into master Apr 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bbondy
Copy link
Member

bbondy commented Apr 17, 2017

Posted an issue to track for this here:
#8047 (comment)

@gyandeeps gyandeeps deleted the env-57 branch Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.