Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add newPrivateTab #8074

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Add newPrivateTab #8074

merged 1 commit into from
Apr 7, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Apr 5, 2017

Automated test plan

npm run test -- --grep="renders newPrivateTab page if isIncognito props is true"

Test plan

Below screenshot should show by any means when opening a new private tab (NOTE: copy may be updated in a later issue)

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bsclifton, @bbondy

Close #7934

screen shot 2017-04-04 at 9 56 33 pm

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! @bradleyrichter may have an update for the text, but I'll merge for now 😄

@bsclifton bsclifton merged commit 8d32bfa into brave:master Apr 7, 2017
@cezaraugusto cezaraugusto deleted the newtab/privatetab branch April 7, 2017 17:44
cezaraugusto added a commit that referenced this pull request May 16, 2017
-
This landed in #8074 but somehow regressed
-
Fix #8895
Auditors: @bradleyrichter
Test Plan: new private tab paragraphs should be properly spaced
bsclifton pushed a commit that referenced this pull request May 17, 2017
-
This landed in #8074 but somehow regressed
-
Fix #8895
Auditors: @bradleyrichter
Test Plan: new private tab paragraphs should be properly spaced
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants