Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Add newPrivateTab #8074

Merged
merged 1 commit into from Apr 7, 2017
Merged

Add newPrivateTab #8074

merged 1 commit into from Apr 7, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Apr 5, 2017 •
edited by bsclifton

Automated test plan

npm run test -- --grep="renders newPrivateTab page if isIncognito props is true"

Test plan

Below screenshot should show by any means when opening a new private tab (NOTE: copy may be updated in a later issue)

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Auditors: @bsclifton, @bbondy

Close #7934

screen shot 2017-04-04 at 9 56 33 pm
@cezaraugusto
Add newPrivateTab
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits
Loading status checks…
8714e57 
- Auditors: @bsclifton, @bbondy
- Close #7934
@cezaraugusto cezaraugusto added this to the 0.14.2 milestone Apr 5, 2017
@cezaraugusto cezaraugusto self-assigned this Apr 5, 2017
@bsclifton
bsclifton reviewed Apr 7, 2017
View changes
Copy link
Member

bsclifton left a comment

Works great! @bradleyrichter may have an update for the text, but I'll merge for now 😄
@bbondy bbondy mentioned this pull request Apr 7, 2017
Closed
@bsclifton bsclifton merged commit 8d32bfa into brave:master Apr 7, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cezaraugusto cezaraugusto deleted the cezaraugusto:newtab/privatetab branch Apr 7, 2017
@cezaraugusto cezaraugusto mentioned this pull request May 16, 2017
Closed
cezaraugusto added a commit that referenced this pull request May 16, 2017
@cezaraugusto
Readd spacing between text for new private tab
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits
Loading status checks…
6ec02d8 
-
This landed in #8074 but somehow regressed
-
Fix #8895
Auditors: @bradleyrichter
Test Plan: new private tab paragraphs should be properly spaced
bsclifton added a commit that referenced this pull request May 17, 2017
@cezaraugusto @bsclifton
Readd spacing between text for new private tab
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
fc8b1aa 
-
This landed in #8074 but somehow regressed
-
Fix #8895
Auditors: @bradleyrichter
Test Plan: new private tab paragraphs should be properly spaced
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

@jamesmudgett jamesmudgett

@bbondy bbondy

@NejcZdovc NejcZdovc

@bradleyrichter bradleyrichter

Assignees

@cezaraugusto cezaraugusto

Labels
QA/test-plan-specified feature/newtab privacy release-notes/include
Projects
None yet
Milestone
  0.15.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cezaraugusto @bsclifton
You can’t perform that action at this time.