Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Replaced data-test-id with testId in Button #8089

Merged
merged 1 commit into from Apr 5, 2017
Merged

Replaced data-test-id with testId in Button #8089

merged 1 commit into from Apr 5, 2017

Conversation

@luixxiul
Copy link
Contributor

luixxiul commented Apr 5, 2017 •
edited

Auditors:

Test Plan: n/a

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:
@luixxiul luixxiul requested a review from NejcZdovc Apr 5, 2017
Suguru Hirahara
Replaced data-test-id with testId in Button
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
87e2f0a 
Auditors:

Test Plan: n/a
@NejcZdovc
NejcZdovc approved these changes Apr 5, 2017
View changes
Copy link
Member

NejcZdovc left a comment

LGTM
@luixxiul luixxiul merged commit 35dbdb1 into brave:master Apr 5, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@luixxiul luixxiul deleted the luixxiul:fix-braveShieldButton branch Apr 5, 2017
@luixxiul luixxiul added this to the 0.14.2 milestone Apr 5, 2017
@NejcZdovc
Copy link
Member

NejcZdovc commented Apr 5, 2017

@luixxiul let's fix this as well, while we are at it:

js/components/updateBar.js L66 L78 L101 L106
@luixxiul luixxiul restored the luixxiul:fix-braveShieldButton branch Apr 5, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 5, 2017

Adding other fixes with cx.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc

Assignees
No one assigned
Labels
QA/no-qa-needed automated-tests
Projects
None yet
Milestone
  0.15.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@luixxiul @NejcZdovc @cndouglas
You can’t perform that action at this time.