This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange tab loading icon #8160
Merged
Change tab loading icon #8160
Conversation
- Auditors: @bsclifton - Close #7265 - Close #7779
This was referenced Apr 10, 2017
|
++ |
jaredbeck
commented
May 2, 2017
|
I'm running brave 0.15.1 and I don't see a spinner at all. Never have. How do I enable spinners? Thanks. |
|
hey @jaredbeck thanks for checking. It's an issue that happened after this PR and we're tracking already, feel free to keep tracking at #8550 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cezaraugusto commentedApr 10, 2017
git rebase -ito squash commits (if needed).Change tab loading icon
Close #7265
Close #7779
QA Steps:
Interface should match GIF:
(orange on non-themed tabs - same color as title for other cases)