Skip to content
This repository has been archived by the owner. It is now read-only.

Add open bookmark in new window #8218

Merged
merged 1 commit into from Apr 17, 2017
Merged

Add open bookmark in new window #8218

merged 1 commit into from Apr 17, 2017

Conversation

@cndouglas
Copy link

cndouglas commented Apr 11, 2017

Closes #8063

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. If there is not an item in the bookmarks toolbar, add one with Bookmark Page.
  2. Right-click the bookmark and click Open Link in New Window.
  3. Make sure the bookmarked page opens in a new window.

Screenshot:
image

Liunkae
Closes #8063
@bbondy
Copy link
Member

bbondy commented Apr 17, 2017

++ thanks

@bbondy bbondy merged commit 85183c6 into brave:master Apr 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cndouglas cndouglas deleted the cndouglas:bookmark-new-window branch Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.