This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove most references to currentWindow and lazy load the rest #8220
Conversation
bridiver
force-pushed the
current-window
branch
4 times, most recently
from
6ecd4ef
to
05b8ae6
|
updated with unit test fix |
bridiver
force-pushed the
current-window
branch
2 times, most recently
from
4549ad3
to
58659fa
| @@ -169,7 +169,7 @@ class Navigator extends ImmutableComponent { | |||
| if (!e.target.className.includes('navigatorWrapper')) { | |||
| return | |||
| } | |||
| return !isMaximized() ? currentWindow.maximize() : currentWindow.unmaximize() | |||
| return !isMaximized() ? windowActions.shouldMaximize(getCurrentWindowId()) : windowActions.shouldMinimize(getCurrentWindowId()) | |||
This comment has been minimized.
This comment has been minimized.
bbondy
Apr 12, 2017
Member
I guess should* is kind of like *Requested for tab creation, maybe we should use one or the other. No need to hold this up though just thinking out loud.
This comment has been minimized.
This comment has been minimized.
bridiver
Apr 12, 2017
Author
Collaborator
these are really just temporary to replace the currentWindow.method calls. This should really be onNavigatorDoubleClick or something like that
This comment has been minimized.
This comment has been minimized.
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bridiver commentedApr 11, 2017
check for automated tests to pass before merging