This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove unnecessary `frames` property from `closeWindow` #8256
Conversation
| @@ -1002,11 +997,9 @@ class Main extends ImmutableComponent { | |||
| sortedFrames.map((frame) => | |||
| <Frame | |||
| ref={(node) => { this.frames[frame.get('key')] = node }} | |||
| tabData={this.props.appState.get('tabs').find((tab) => tab.get('tabId') === frame.get('tabId'))} | |||
This comment has been minimized.
This comment has been minimized.
bridiver
Apr 12, 2017
•
Author
Collaborator
this was just a random prop that wasn't being used anywhere
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bsclifton
Apr 13, 2017
•
Member
@bridiver I don't remember the original use-case, but I did use this when implementing the per-tab alerts (but then removed in favor of a distinct messageBoxDetail property- part of tab object)
|
++ pls merge as long as tests pass |
|
@bbondy test are failing, but they are failing for master as well, so it's not related to this change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bridiver commentedApr 12, 2017
cc @bbondy