Skip to content
This repository has been archived by the owner. It is now read-only.

Prevent webpack from generating source maps in production builds #8262

Closed
wants to merge 1 commit into from

Conversation

@bsclifton
Copy link
Member

bsclifton commented Apr 12, 2017

Test Plan:

?? - I need help verifying how to test this. I tried npm run build-package but didn't see file in either case.

Description

Fixes #8255

Auditors: @jonathansampson, @bbondy, @bridiver

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
Fixes #8255

Auditors: @jonathansampson, @bbondy

Test Plan:
?? - I need help verifying how to test this. I tried `npm run build-package` but didn't see file in either case.
@bsclifton bsclifton added the dev-setup label Apr 12, 2017
@bsclifton bsclifton added this to the 0.14.2 milestone Apr 12, 2017
@bsclifton bsclifton self-assigned this Apr 12, 2017
@bridiver
Copy link
Collaborator

bridiver commented Apr 12, 2017

I'm pretty sure this is not the right change to make. I don't know what the default is, but the docs say Note: With the next major version the default for -d will change to cheap-module-eval-source-map
If we don't want the source maps in the release we should leave them out when building the asar file

@bridiver
Copy link
Collaborator

bridiver commented Apr 12, 2017

I'd also like to see what we get in the console without any source maps at all. We don't want even less debugging info than we already have

@bsclifton
Copy link
Member Author

bsclifton commented Apr 12, 2017

@bridiver those are good points- I'm going to go ahead and close this PR out and we can re-assess the issue

@bsclifton bsclifton closed this Apr 12, 2017
@bsclifton bsclifton deleted the bsclifton:remove-source-map branch Apr 12, 2017
@bsclifton bsclifton removed this from the 0.15.0 milestone Apr 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.