This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPrevent webpack from generating source maps in production builds #8262
Conversation
Fixes #8255 Auditors: @jonathansampson, @bbondy Test Plan: ?? - I need help verifying how to test this. I tried `npm run build-package` but didn't see file in either case.
|
I'm pretty sure this is not the right change to make. I don't know what the default is, but the docs say |
|
I'd also like to see what we get in the console without any source maps at all. We don't want even less debugging info than we already have |
|
@bridiver those are good points- I'm going to go ahead and close this PR out and we can re-assess the issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedApr 12, 2017
Test Plan:
?? - I need help verifying how to test this. I tried
npm run build-packagebut didn't see file in either case.Description
Fixes #8255
Auditors: @jonathansampson, @bbondy, @bridiver
git rebase -ito squash commits (if needed).