Locks versions of npm packages #8284

NejcZdovc · 2017-04-13T07:22:14Z

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).

Resolves #8283

Test Plan:

test passing


        Locks versions of npm packages

@bsclifton

Resolves #8283 Auditors: @bsclifton Test Plan: - test passing

bbondy · 2017-04-17T15:22:47Z

I think we'd have to use npm shrinkwrap or get yarn to work. This will only lock the top level versions, but each of those packages have fuzzy deps.

NejcZdovc · 2017-04-19T06:04:26Z

Closing in favor of #7795

Locks versions of npm packages

Unverified

This user has not uploaded their public key yet.

GPG key ID: 584931E990AC6064 Learn about signing commits

Loading status checks…

044e77a

Resolves #8283 Auditors: @bsclifton Test Plan: - test passing

NejcZdovc added the infrastructure label Apr 13, 2017

NejcZdovc added this to the 0.14.3 milestone Apr 13, 2017

NejcZdovc self-assigned this Apr 13, 2017

NejcZdovc requested a review from bsclifton Apr 13, 2017

bbondy removed this from the 0.15.1 milestone Apr 17, 2017

NejcZdovc closed this Apr 19, 2017

brave / browser-laptop Archived

Locks versions of npm packages #8284

Locks versions of npm packages #8284

NejcZdovc commented Apr 13, 2017

bbondy commented Apr 17, 2017

NejcZdovc commented Apr 19, 2017

brave / browser-laptop Archived

Join GitHub today

Locks versions of npm packages #8284

Locks versions of npm packages #8284

Conversation

NejcZdovc commented Apr 13, 2017

bbondy commented Apr 17, 2017

NejcZdovc commented Apr 19, 2017