This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove the FAQ link next to the payment on/off toggle #8337
Merged
Conversation
…to auto-include) This is a suggestion, but I think it makes more sense here. See issue details for more info: #7796 Fixes #7796 Auditors: @bradleyrichter, @luixxiul Test Plan: 1. Launch Brave and open Preferences > Payments 2. You should see the "?" icon next to the on/off switch 3. Toggle the on/off switch; it should still show after changing 4. Click link and confirm it goes to Payment FAQ
|
LGTM |
|
I think this was a bandaid. ; ) We should get Marketing to write the content and move it back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedApr 15, 2017
(instead of next to auto-include)
This is a suggestion, but I think it makes more sense here. See issue details for more info:
#7796
Fixes #7796
Auditors: @bradleyrichter, @luixxiul
Test Plan:
git rebase -ito squash commits (if needed).