Skip to content
This repository has been archived by the owner. It is now read-only.

Moves bookmarks related files into app folder #8352

Merged
merged 1 commit into from Apr 17, 2017

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented Apr 17, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8351

What was done

  1. moved files from js to app folder
  2. split components to a single file per component principle

Auditors

@bsclifton @cezaraugusto

Test Plan

  • test should be green
… to a single file per component

Resolves #8351

Auditors: @bsclifton

Test Plan:
- test should be green
- everything should be the same
@NejcZdovc NejcZdovc added this to the 0.14.3 milestone Apr 17, 2017
@NejcZdovc NejcZdovc self-assigned this Apr 17, 2017
@NejcZdovc NejcZdovc requested review from cezaraugusto and bsclifton Apr 17, 2017
Copy link
Member

bsclifton left a comment

++

@bsclifton bsclifton merged commit 67f42e8 into brave:master Apr 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.