This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds non-verified option to the payment page #8394
Merged
+93
−18
Conversation
|
doesn't there need to br something added to ledger.js to make use of this option??? |
|
@mrose17, these PR is not yet completed, still have work-in-progress label |
NejcZdovc
force-pushed the
NejcZdovc:feature/#8231-verified
branch
from
e4be1d3
to
229de66
|
LGTM. |
NejcZdovc
force-pushed the
NejcZdovc:feature/#8231-verified
branch
from
229de66
to
3f83263
NejcZdovc
force-pushed the
NejcZdovc:feature/#8231-verified
branch
3 times, most recently
from
696ef4b
to
798f177
js/constants/appConfig.js
Outdated
| @@ -149,6 +149,7 @@ module.exports = { | |||
| 'bookmarks.toolbar.showOnlyFavicon': false, | |||
| 'payments.enabled': false, | |||
| 'payments.notifications': false, | |||
| 'payments.non-verified-publishers': true, | |||
This comment has been minimized.
This comment has been minimized.
bsclifton
Apr 24, 2017
Member
Could you update this to be more descriptive? Maybe payments.allow-non-verified-publishers?
This comment has been minimized.
This comment has been minimized.
js/constants/settings.js
Outdated
| @@ -55,6 +55,7 @@ const settings = { | |||
| PAYMENTS_NOTIFICATION_RECONCILE_SOON_TIMESTAMP: 'notification-reconcile-soon-timestamp', | |||
| PAYMENTS_NOTIFICATION_TRY_PAYMENTS_DISMISSED: 'payments.notificationTryPaymentsDismissed', | |||
| PAYMENTS_CONTRIBUTION_AMOUNT: 'payments.contribution-amount', | |||
| PAYMENTS_NON_VERIFIED: 'payments.non-verified-publishers', | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Resolves #8231 Auditors: @mrose17 @bsclifton Test Plan: - go to payments page - click on advance settings - disabled option "Allow contributions to non-verified sites" - all non-verified sites should be hidden from a table
NejcZdovc
force-pushed the
NejcZdovc:feature/#8231-verified
branch
from
798f177
to
462d4aa
|
Manually tested and also ran the webdriver test. Changes work as expected. Great job |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
NejcZdovc commentedApr 19, 2017
•
edited
git rebase -ito squash commits (if needed).Resolves #8231
Auditors: @mrose17 @bsclifton
Test Plan