This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upView page source for local files #8404
Merged
Conversation
cndouglas
commented
Apr 21, 2017
|
Thanks @romamatusevich! Unfortunately, there are conflicts because of some recent commits. Could you please resolve them? |
|
Hello @Liunkae, The conflicts were resolved. |
cndouglas left a comment
|
Works great! |
cndouglas
commented
Apr 22, 2017
|
@romamatusevich Please squash the two commits. Thanks for adding tests, by the way! |
|
@Liunkae, rebased the changes to have one commit only. |
|
Awesome!! Thanks for the patch @romamatusevich |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
romamatusevich commentedApr 19, 2017
•
edited
The file uri scheme has been made allowed for view source
fix #8049
Original issue: #8049
git rebase -ito squash commits (if needed).Test Plan: