This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate min-threshold for closing a tab #8411
Merged
Conversation
- Auditors: @bsclifton, @NejcZdovc - Close #8130 - Test Plan: covered by automated tests
|
Just tested and it's a great improvement. Approved my me... |
|
++ killer job on the tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cezaraugusto commentedApr 20, 2017
•
edited by NejcZdovc
git rebase -ito squash commits (if needed).Resolves #8130
please don't squash, one commit is just for tests✅
Test Plan:
Manual Tests:
Test Plan: