Skip to content
This repository has been archived by the owner. It is now read-only.

Implement app.dock.downloadFinished #8418

Merged
merged 1 commit into from Apr 26, 2017
Merged

Implement app.dock.downloadFinished #8418

merged 1 commit into from Apr 26, 2017

Conversation

@cndouglas
Copy link

cndouglas commented Apr 21, 2017

Make the Downloads folder dock icon "bounce" when a download is complete (macOS-only).

Resolves #1667

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Navigate to https://brave.com/ .
  2. Click Get Brave and then click Save.
  3. As the download progress bar approaches 100%, look at the Downloads folder dock icon.
  4. Make sure the dock icon "bounces" when the download finishes.
Liunkae
Make the Downloads folder dock icon "bounce" when a download is complete (macOS-only).

Resolves #1667
@cndouglas
Copy link
Author

cndouglas commented Apr 22, 2017

Question: should the code be placed in electronDownloadItem.js or app/filtering.js?

@bbondy bbondy force-pushed the brave:master branch from f0df59d to 70e5d77 Apr 23, 2017
@bbondy
Copy link
Member

bbondy commented Apr 26, 2017

It's good there. Thanks, works great.

@bbondy bbondy merged commit 4af63f4 into brave:master Apr 26, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cndouglas cndouglas deleted the cndouglas:dock-download-finished branch Apr 26, 2017
@alexwykoff
Copy link
Contributor

alexwykoff commented May 24, 2017

I wasn't able to replicate in 0.15.307, did this get reverted?

@luixxiul
Copy link
Contributor

luixxiul commented May 24, 2017

@luixxiul
Copy link
Contributor

luixxiul commented May 24, 2017

so it seems like it's not.

@cndouglas
Copy link
Author

cndouglas commented May 24, 2017

It's working for me with the latest master (6a9a017).

@cndouglas
Copy link
Author

cndouglas commented May 24, 2017

Also works for me with 0.15.307 on macOS 10.12.x.

@alexwykoff
Copy link
Contributor

alexwykoff commented May 25, 2017

we're currently building 0.15.3xx releases off of dev-channel, so master may be ahead 😄

@cndouglas
Copy link
Author

cndouglas commented May 26, 2017

@alexwykoff Good to know. I can confirm this feature is working with the version just released (0.15.310, 6b5e4e2).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.