This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement app.dock.downloadFinished #8418
Merged
Conversation
|
Question: should the code be placed in |
|
It's good there. Thanks, works great. |
|
I wasn't able to replicate in 0.15.307, did this get reverted? |
|
so it seems like it's not. |
|
It's working for me with the latest master (6a9a017). |
|
Also works for me with 0.15.307 on macOS 10.12.x. |
|
we're currently building 0.15.3xx releases off of dev-channel, so master may be ahead |
|
@alexwykoff Good to know. I can confirm this feature is working with the version just released (0.15.310, 6b5e4e2). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cndouglas commentedApr 21, 2017
Make the Downloads folder dock icon "bounce" when a download is complete (macOS-only).
Resolves #1667
git rebase -ito squash commits (if needed).Test Plan:
Get Braveand then clickSave.