This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCleanup the multi-type context menu item #8503
Merged
Conversation
cndouglas left a comment
|
Works for me. |
|
Works great lint passes, unit tests pass, and webdrivers tests using |
|
@ardcore congrats on your 1st commit landing in Brave |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ardcore commentedApr 26, 2017
•
edited by bsclifton
This fixes #7816 and simplifies the logic of context menu item by making a distinction between the
submenucollection and the structure of a multi-type item.By creating a new collection (
items), we're able to treat themulti-item as a normal item (sharing all it's behaviours -- lack of them was the precise cause of #7816 ). This also solves some other, probably unfilled issues (i.e, it wasn't possible to focus themulti-type item using keyboard[1]), and makes it possible to definemulti-type items with submenus, if needed.[1] - While this PR makes it possible to select the
multi-item, keyboard navigation still won't work inside it. I believe this should be discussed in another issue.git rebase -ito squash commits (if needed).Test Plan:
See #7816