Skip to content
This repository has been archived by the owner. It is now read-only.

fix #8374 - Open image in new tab should recognize focus prefs #8509

Merged
merged 1 commit into from Apr 29, 2017

Conversation

@jamesmudgett
Copy link
Contributor

jamesmudgett commented Apr 26, 2017

Test plan

  1. In Preferences > Tabs, set "Switch to new tabs immediately" to false
  2. Visit a site with images (ex: cnn.com)
  3. Right click an image and pick "Open Image in New Tab"
  4. Image should open in new tab- but focus is not sent
  5. Toggle the setting (set in step 1)
  6. Right click an image and pick "Open Image in New Tab"
  7. Focus should be given immediately to the new tab

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #8374

@jamesmudgett jamesmudgett requested a review from bsclifton Apr 26, 2017
@jamesmudgett
Copy link
Contributor Author

jamesmudgett commented Apr 26, 2017

#8374 was bugging me, also.

Copy link
Member

bsclifton left a comment

Awesome, thanks James! 😄

@bsclifton bsclifton merged commit 63741d4 into master Apr 29, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bsclifton bsclifton deleted the issue-8374 branch Apr 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.