Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmove the nav controls to left in full screen mode - in macOS Fix #7872 #8514
Conversation
cndouglas left a comment
|
Please look for something like |
|
@luixxiul How should i check, if screen is in full screen mode or not? |
|
@kumarrishav so instead of modifying less file, you need to modify some js file. More specifically |
| @@ -225,7 +225,7 @@ class Navigator extends ImmutableComponent { | |||
| onDragOver={this.onDragOver} | |||
| onDrop={this.onDrop} | |||
| > | |||
| <div className='backforward'> | |||
| <div className={'backforward' + (isFullScreen() ? ' fullscreen' : '')}> | |||
This comment has been minimized.
This comment has been minimized.
NejcZdovc
Apr 28, 2017
Member
Please use cx syntax for class name, you can see example bellow. Thank you
This comment has been minimized.
This comment has been minimized.
kumarrishav
Apr 28, 2017
Author
Contributor
fixed. I wasn't aware of this utility func. @NejcZdovc Thanks .
cndouglas left a comment •
|
Great job! Works for me. It even animates when you toggle fullscreen. |
|
Very nice- works great |



kumarrishav commentedApr 26, 2017
•
edited by bsclifton
Test plan
Description
git rebase -ito squash commits (if needed).Resolves #7872
Test Plan:
