Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Opening PDF via Wayback machine should not change the url Fix #6726 #8518

Merged
merged 1 commit into from Apr 29, 2017
Merged

Opening PDF via Wayback machine should not change the url Fix #6726 #8518

merged 1 commit into from Apr 29, 2017

Conversation

@kumarrishav
Copy link
Contributor

kumarrishav commented Apr 27, 2017 •
edited by luixxiul

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Fix #6726
@kumarrishav
Opening PDF via Wayback machine should not change the url Fix #6726
Loading status checks…
7a3190d
@srirambv srirambv requested review from diracdeltas and bsclifton Apr 27, 2017
@srirambv srirambv added this to the 0.15.1 milestone Apr 27, 2017
@diracdeltas
diracdeltas approved these changes Apr 27, 2017
View changes
@diracdeltas diracdeltas merged commit 4d2b95e into brave:master Apr 29, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bsclifton
Copy link
Member

bsclifton commented Apr 29, 2017

Great job, thanks @kumarrishav! 😄
@kumarrishav kumarrishav self-assigned this May 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diracdeltas diracdeltas

@bsclifton bsclifton

Assignees

@kumarrishav kumarrishav

Labels
feature/URLbar feature/extensions
Projects
None yet
Milestone
  0.15.300 (Frozen,...
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@kumarrishav @bsclifton @diracdeltas @luixxiul @srirambv
You can’t perform that action at this time.