Skip to content
This repository has been archived by the owner. It is now read-only.

show nothing for siteInfo on about: pages #8542

Merged
merged 1 commit into from Apr 28, 2017
Merged

show nothing for siteInfo on about: pages #8542

merged 1 commit into from Apr 28, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Apr 27, 2017

fix #8299

Test Plan:

  1. open example.com
  2. open a new tab
  3. show siteInfo on example.com, then use Cmd+2 to switch to the second tab
  4. no siteInfo should show on the second tab
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #8299

Test Plan:
1. open example.com
2. open a new tab
3. show siteInfo on example.com, then use Cmd+2 to switch to the second tab
4. no siteInfo should show on the second tab
@diracdeltas diracdeltas requested a review from darkdh Apr 27, 2017
@diracdeltas diracdeltas added this to the 0.15.1 milestone Apr 27, 2017
@darkdh
darkdh approved these changes Apr 28, 2017
Copy link
Member

darkdh left a comment

lgtm++

@diracdeltas diracdeltas merged commit c88f470 into master Apr 28, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bsclifton bsclifton deleted the fix/8299 branch May 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.