Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd BrowserButton component #8560
Conversation
| } | ||
| }, | ||
| // applies for primary and white buttons | ||
| browserButton_default: { |
This comment has been minimized.
This comment has been minimized.
|
Nice work. As a reminder, would you please apply the change to |
|
sure, thanks for checking ;) |
|
btw @luixxiul I added #8568 as an issue to track this PR since it doesn't refactor all components and removed #7168 reference (added you there as assignee as well) so we can keep tracking until every button uses BrowserButton. Then There are too many files using (now legacy) Button that the likeliness of regression was too high, so I decided to keep it gradual. |
|
FYI: reset Sync will be replaced with the primaryButton after #8044 is merged. |
|
@cezaraugusto I left some comments. |
|
thanks, updated |
- Close #8568 - Auditors: @luixxiul, @NejcZdovc
|
Since comments were addressed, merging. |
|
As I removed Since on the other dialogs the margin exists, I believe something is inconsistent between them. I'll tackle that. |
|
@luixxiul is that expected behaviour for the backup wallet modal? |
|
No, and it was fixed already |

cezaraugusto commentedApr 28, 2017
•
edited
git rebase -ito squash commits (if needed).Auditors: @luixxiul, @NejcZdovc
Close: #8568
Test Plan:
Buttons refactored
Buttons changed as side effect
We had a global selector that changed every button that had
ButtonclassName. I replaced that withnormalizeButtonso standard HTML5 buttons weren't affected. For reference: