Skip to content
This repository has been archived by the owner. It is now read-only.

Fix issue with not working select the last tab preference #8580

Merged
merged 1 commit into from May 1, 2017

Conversation

@romamatusevich
Copy link
Contributor

romamatusevich commented Apr 29, 2017

Test Plan:

  1. Open https://github.com (tab 1)
  2. Open about:preferences#tabs in a new tab (tab 2)
  3. Set "Select the last viewed tab"
  4. Open https://github.com/features in a new tab (tab 3)
  5. Select tab 1
  6. Select tab 3
  7. Close tab 3

Expected result: tab 1 should be selected

Description

Pinned locations for frames were nullified and due to that check by last accessed time didn't work. Added null case and tests for getFrameByLastAccessedTime function.

Fix #8357

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
Pinned locations for frames were nullified and due to that check by last accessed time didn't work. Added null case and tests for getFrameByLastAccessedTime function.

Fix #8357
@Jacalz
Copy link
Collaborator

Jacalz commented Apr 30, 2017

It is getting annoying with pinned tabs not working with this setting, would guess that it is not what this is fixing but it is related kinda 😉 #7332

@bsclifton bsclifton requested review from bsclifton and NejcZdovc Apr 30, 2017
Copy link
Member

bsclifton left a comment

Confirmed before/after- great work on this 😄

Love the tests! 👍

@bsclifton bsclifton merged commit e48ca3e into brave:master May 1, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@bsclifton bsclifton added this to the 0.15.2 milestone May 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.