Skip to content
This repository has been archived by the owner. It is now read-only.

Disable autoplay #8609

Merged
merged 2 commits into from May 5, 2017
Merged

Disable autoplay #8609

merged 2 commits into from May 5, 2017

Conversation

@jonathansampson
Copy link
Collaborator

jonathansampson commented May 1, 2017

Test plan

A.

  1. Go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
  2. Video should not autoplay
  3. Click bravey panel to allow autoplay
  4. Video should autoplay

B.

  1. Go to youtube and watch a video
  2. Video should not autoplay
  3. Click bravey panel to allow autoplay
  4. Video should autoplay

C. Also covered by automatic test


  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Resolves #7663
Resolves #2227
Resolves #4045

@jonathansampson jonathansampson added this to the 0.15.2 milestone May 1, 2017
@jonathansampson jonathansampson requested review from bridiver and darkdh May 1, 2017
@jonathansampson jonathansampson force-pushed the disable-autoplay branch from 794c34d to 704e63b May 1, 2017
Copy link
Member

darkdh left a comment

There should be a global default setting of autoplay preference.

@jonathansampson
Copy link
Collaborator Author

jonathansampson commented May 1, 2017

@darkdh You mean, a switch inside about:preferences#shields?

@darkdh
Copy link
Member

darkdh commented May 1, 2017

yeah, we should let users choose control the default global setting of it

@bridiver
Copy link
Collaborator

bridiver commented May 1, 2017

can we add tests for this? Preferably using a localhost url and not a remote site
otherwise ++

@jonathansampson jonathansampson force-pushed the disable-autoplay branch from 8f2c8da to 5e8ff84 May 2, 2017
@jonathansampson
Copy link
Collaborator Author

jonathansampson commented May 2, 2017

@darkdh Global setting is now set.
@bridiver Working on test(s) next.

@jonathansampson
Copy link
Collaborator Author

jonathansampson commented May 3, 2017

@bridiver Spectron tests aren't running on Windows. I'm going to try and get it working on my Ubuntu VM, but it could be a day or two. Would you be okay with us merging prior to landing tests?

@alexwykoff alexwykoff modified the milestones: 0.15.4, 0.15.3 May 5, 2017
@darkdh
Copy link
Member

darkdh commented May 5, 2017

I can help adding the test from Mac

@darkdh darkdh self-assigned this May 5, 2017
@darkdh darkdh modified the milestones: 0.15.3, 0.15.4 May 5, 2017
@jonathansampson
Copy link
Collaborator Author

jonathansampson commented May 5, 2017

@darkdh That would be awesome! Thanks 🙂

@darkdh
darkdh approved these changes May 5, 2017
@darkdh darkdh merged commit e15b6bd into master May 5, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@mdoniec mdoniec mentioned this pull request May 6, 2017
@bsclifton bsclifton deleted the disable-autoplay branch May 22, 2017
@gary-schiltz
Copy link

gary-schiltz commented Jun 12, 2017

I would also like to see the ability to control the preloading of HTML5 videos, since it consumes bandwidth, even if the user has no intention of watching a video. The desired behavior would be for the browser to act as if the preload attribute of all tags were set to "none" or perhaps "metadata". The test for this would be to clear the browser's cache, visit https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_preload, and watch some type of bandwidth indicator.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.