Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable autoplay #8609
Disable autoplay #8609
Conversation
|
There should be a global default setting of autoplay preference. |
|
@darkdh You mean, a switch inside about:preferences#shields? |
|
yeah, we should let users choose control the default global setting of it |
|
can we add tests for this? Preferably using a localhost url and not a remote site |
|
@bridiver Spectron tests aren't running on Windows. I'm going to try and get it working on my Ubuntu VM, but it could be a day or two. Would you be okay with us merging prior to landing tests? |
|
I can help adding the test from Mac |
|
@darkdh That would be awesome! Thanks |
Auditors: @jonathansampson, @bridiver
gary-schiltz
commented
Jun 12, 2017
|
I would also like to see the ability to control the preloading of HTML5 videos, since it consumes bandwidth, even if the user has no intention of watching a video. The desired behavior would be for the browser to act as if the preload attribute of all tags were set to "none" or perhaps "metadata". The test for this would be to clear the browser's cache, visit https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_preload, and watch some type of bandwidth indicator. |
jonathansampson commentedMay 1, 2017
•
edited by darkdh
Test plan
A.
B.
C. Also covered by automatic test
git rebase -ito squash commits (if needed).Test Plan:
Resolves #7663
Resolves #2227
Resolves #4045