Skip to content
This repository has been archived by the owner. It is now read-only.

Fix alignment of showSuppress message and buttons on messageBox #8622

Merged
merged 1 commit into from May 5, 2017

Conversation

@luixxiul
Copy link
Contributor

luixxiul commented May 2, 2017

Closes #8598

Auditors:

Test Plan:

  1. Open about:preferences#sync
  2. Click "Reset Sync"
  3. Click "Reset Sync" on the modal dialog
  4. Click "Cancel"
  5. Click "Reset Sync" again
  6. Make sure there exists margin between the supress message and the buttons on the footer
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
Suguru Hirahara
Closes #8598

Auditors:

Test Plan:
1. Open about:preferences#sync
2. Click "Reset Sync"
3. Click "Reset Sync" on the modal dialog
4. Click "Cancel"
5. Click "Reset Sync" again
6. Make sure there exists margin between the supress message and the buttons on the footer
@luixxiul luixxiul added this to the 0.15.2 milestone May 2, 2017
@luixxiul luixxiul self-assigned this May 2, 2017
@luixxiul luixxiul requested review from cezaraugusto and srirambv May 2, 2017
Copy link
Contributor

cezaraugusto left a comment

++

@cezaraugusto cezaraugusto merged commit 164c1c6 into brave:master May 5, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@luixxiul luixxiul deleted the luixxiul:fix-messageBox branch May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.