Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Fix loading tab regression #8631

Merged
merged 2 commits into from May 8, 2017
Merged

Fix loading tab regression #8631

merged 2 commits into from May 8, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 2, 2017

Auditors: @bbondy, @bsclifton
Fix #8550

Test Plan:
loading icon should be visible while reloading a tab
@cezaraugusto cezaraugusto added this to the 0.15.2 milestone May 2, 2017
@cezaraugusto cezaraugusto self-assigned this May 2, 2017
@cezaraugusto cezaraugusto requested review from bbondy and bsclifton May 2, 2017
@bsclifton
Copy link
Member

bsclifton commented May 2, 2017

It might not be straightforward, but I'd love to see tests around this if you are able to @cezaraugusto 😄

We'd need to mock AppDispatcher, from which we can get the reference to doAction when register is called. Then we can call passing in windowConstants.WINDOW_WEBVIEW_LOAD_START and verify the result modified the window state appropriately
cezaraugusto and others added 2 commits May 2, 2017
@cezaraugusto
Fix loading tab regression
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits
99dbc3f 
- Auditors: @bbondy, @bsclifton
- Fix #8550
- Test Plan: loading icon should be visible
@bsclifton @cezaraugusto
Add unit test for windowStore
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits
Loading status checks…
e23e1be 
Run using `npm run unittest -- --grep="Window store unit tests"`

Auditors: @cezaraugusto
@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented May 6, 2017

ok rebased + amended some more tests, ready for re-review
@bbondy
Copy link
Member

bbondy commented May 8, 2017

++, took me a minute to see it, but was resulting in ['tabs', 'frames', ...]
@bbondy bbondy merged commit 769f7a0 into brave:master May 8, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jpretori jpretori mentioned this pull request May 8, 2017
Closed
@bbondy

This comment has been minimized.

Sign in to view
Copy link
Member

bbondy commented on js/stores/windowStore.js in 99dbc3f May 8, 2017

screenshot 2017-05-08 00 13 51
@bsclifton
Copy link
Member

bsclifton commented May 8, 2017

++! 😄
@cezaraugusto cezaraugusto deleted the cezaraugusto:tabsbar/8550 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy

@bsclifton bsclifton

Assignees

@cezaraugusto cezaraugusto

Labels
feature/tabsbar
Projects
None yet
Milestone
  0.15.300 (Frozen,...
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@cezaraugusto @bsclifton @bbondy
You can’t perform that action at this time.