Skip to content
This repository has been archived by the owner. It is now read-only.

Cambio en el icono de Bookmark import (Remove, this pull request is not valid, sorry) #8655

Closed
wants to merge 7 commits into from

Conversation

@PedroJ1
Copy link

PedroJ1 commented May 3, 2017

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

@PedroJ1 PedroJ1 closed this May 3, 2017
@PedroJ1 PedroJ1 changed the title Cambio en el icono de Bookmark import Cambio en el icono de Bookmark import (Remove, this pull request is not valid, sorry) May 3, 2017
@bsclifton
Copy link
Member

bsclifton commented May 3, 2017

@PedroJ1 porque cerrado? Tienes una screenshot de la icono nuevo?

@PedroJ1
Copy link
Author

PedroJ1 commented May 3, 2017

I thought that close the Pull request would be the best option to see that it was an error. I was teaching in a project of the University how to contribute helping to the Brave community making a change in Brave development and publishing the changes in the original repository of Brave, but finally I clicked on "Create Pull Request" by mistake. (The icon is the Brave logo, it hasn't sense, it was only an example to how to make a change in Brave development). My apologies.

screenshot from 2017-05-03 18-28-49

@bsclifton
Copy link
Member

bsclifton commented May 3, 2017

@PedroJ1 no need to apologize- that is really cool! 🦁 Please let us know if there's anything you or students need help with. Thanks for sharing our project 😄

@PedroJ1
Copy link
Author

PedroJ1 commented May 3, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.