Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

switch from node-uuid to uuid #8668

Merged
merged 1 commit into from May 5, 2017
Merged

switch from node-uuid to uuid #8668

merged 1 commit into from May 5, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented May 3, 2017 •
edited

fix #8667

Test Plan:
N/A

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:
@diracdeltas
switch from node-uuid to uuid
Loading status checks…
2ff7918 
fix #8667

Test Plan:
N/A
@diracdeltas diracdeltas added this to the 0.15.3 milestone May 3, 2017
@diracdeltas diracdeltas self-assigned this May 3, 2017
@diracdeltas diracdeltas requested review from mrose17 and bbondy May 3, 2017
@mrose17
mrose17 approved these changes May 3, 2017
View changes
Copy link
Member

mrose17 left a comment

LGTM.
@bbondy
Copy link
Member

bbondy commented May 5, 2017

++
@bbondy bbondy merged commit 5c6e5c2 into master May 5, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@luixxiul luixxiul deleted the fix/uuid branch May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrose17 mrose17

@bbondy bbondy

Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
  0.15.300 (Frozen,...
Linked issues

Successfully merging this pull request may close these issues.

switch from node-uuid to uuid
3 participants
@diracdeltas @bbondy @mrose17
You can’t perform that action at this time.