Browser crash with payment enabled when clearing browsing data

[mrose17]

Test Plan:

1. start browser
2. oh, the places you will go!
3. clear all browser data via preferences>security
4. no crash: winner!

Description

40abc0c
065d1c784268b47#diff-8a9bac13ef6264feb2b6da7c18d86b3cL733 and
40abc0c
065d1c784268b47#diff-8a9bac13ef6264feb2b6da7c18d86b3cL746 you’ll see
that the old code had a catch to deal with clean-up errors. The new
code doesn’t. This fixes that in filtering.js … whether or not there
should be a catch is a different issue.

Also, in tabs.js, I consistently get a crash when starting up my test
browser, this fixes that.

Fixes #8659 ... this has nothing to do with the ledger, afaik...

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

[bridiver]

actually it looks like the catch was hiding the fact that the method was always throwing an exception. You're right that we don't want to add a catch, we want to fix the method call so it doesn't throw an exception every time

[mrose17]

@bridiver - i agree, but this is outside of my area, so i'm deferring to you, @bsclifton and @bbondy to figure out the rea fix...

[bsclifton]

@bridiver before I can test this out, I need your help resolving the merge conflict. It conflicts with the commit you did most recently: 33e3fca

[mrose17]

@bsclifton -please resolve the conflicts in favor of my PR. it supersedes the checkin done by @bridiver

the only difference is that i added a .bind(ses) to what @bridiver did...

[alexwykoff]

need to get to stable release so needs to be finished todayish, also needs test plan

[mrose17]

@bsclifton - conflicts resolved.

[bsclifton]

++

[bsclifton]

awesome, thanks @mrose17 😄

Per request from @alexwykoff, do you mind adding a test plan?

[mrose17]

@bsclifton - done.