This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOptimize URL bar history and bookmark suggestions (generateNewSuggestionsList()) #8692
Conversation
ayumi
changed the title
ayumi
force-pushed the
fix/url-bar-autocomplete
branch
2 times, most recently
from
c3fadb9
to
e019197
| let bookmarkSites = new Immutable.List() | ||
| const sites = appStoreRenderer.state.get('sites') | ||
| sites.forEach(site => { | ||
| if (!sitesFilter(site)) { |
This comment has been minimized.
This comment has been minimized.
ayumi
May 4, 2017
Author
Contributor
Note for reviewers: this is most important change, to filter out non-matching sites as soon as possible to avoid downstream property lookup
| return false | ||
| } | ||
| const title = site.get('title') | ||
| return location.toLowerCase().includes(urlLocationLower) || |
This comment has been minimized.
This comment has been minimized.
bsclifton
May 4, 2017
Member
Per our discussion on Slack, I wonder if this could be sped up using indexOf? Link you shared: https://jsperf.com/regexp-test-vs-string-includes-vs-string-indexof
This comment has been minimized.
This comment has been minimized.
ayumi
May 4, 2017
Author
Contributor
thanks! i've updated this PR to use indexOf instead of includes.
Related to #7453 Auditors: @bsclifton @bbondy
|
lgtm |
This comment has been minimized.
This comment has been minimized.
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedMay 4, 2017
•
edited
Related to #7453
With 10,000 sites, time to run
generateNewSuggestionsList():Auditors: @darkdh @bbondy
git rebase -ito squash commits (if needed).Test Plan:
npm run test -- --grep="^urlBarSuggestions"