This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse fast-url-parser #8708
Merged
Use fast-url-parser #8708
Conversation
| // In fast-url-parser href, port, prependSlash, protocol, and query | ||
| // are lazy so access them. | ||
| const raw = urlParse(url, ...args) | ||
| parsedUrl = { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ayumi
May 5, 2017
Author
Contributor
The first 5 properties are lazy / accessor functions, so this is to populate those properties.
This comment has been minimized.
This comment has been minimized.
|
++ |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ayumi commentedMay 5, 2017
•
edited
Use faster implementation of
url.parse().Related to #7453. With 10K bookmarks, the URL bar first letter latency reduces from 2600 ms to 1700 ms.
Fix #8707
Auditors: @bsclifton @bbondy
Test Plan:
Related benchmark: