Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

fallback to local data when extension is disabled #8721

Merged
merged 1 commit into from May 5, 2017
Merged

fallback to local data when extension is disabled #8721

merged 1 commit into from May 5, 2017

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 5, 2017

Auditors: @bbondy
Fix #8720

Test Plan:

  • Disable an extension
  • Check that "version" is set as "latest" (because it's dummy data).
  • Enable extension
  • Check that "version" match extension version. (because data is fetched from manifest)
@cezaraugusto
fallback to local data when extension is disabled
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: ECC5FF1C7EA1D39D Learn about signing commits
Loading status checks…
ab727cb 
- Auditors: @bbondy
- Fix #8720
@cezaraugusto cezaraugusto added this to the 0.15.3 milestone May 5, 2017
@cezaraugusto cezaraugusto self-assigned this May 5, 2017
@cezaraugusto cezaraugusto requested a review from bbondy May 5, 2017
@bbondy
Copy link
Member

bbondy commented May 5, 2017

++
@bbondy bbondy merged commit 0921052 into master May 5, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cezaraugusto cezaraugusto mentioned this pull request May 5, 2017
Closed
@bsclifton bsclifton deleted the extension/8720 branch May 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbondy bbondy

Assignees

@cezaraugusto cezaraugusto

Labels
feature/extensions
Projects
None yet
Milestone
  0.15.300 (Frozen,...
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cezaraugusto @bbondy
You can’t perform that action at this time.