Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

In nav bar bookmarked star, check only the specific siteKey #8771

Closed
wants to merge 1 commit into from
Closed

In nav bar bookmarked star, check only the specific siteKey #8771

wants to merge 1 commit into from

Conversation

@ayumi
Copy link
Contributor

ayumi commented May 9, 2017 •
edited

Fix #8703

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:
@ayumi ayumi self-assigned this May 9, 2017
@ayumi ayumi changed the title Upgrade lru-cache and cache siteUtil.isSiteBookmarked() Upgrade lru-cache and cache isSiteBookmarked() for nav bar May 9, 2017
@ayumi ayumi changed the title Upgrade lru-cache and cache isSiteBookmarked() for nav bar Upgrade lru-cache and cache isSiteBookmarked() in nav bar May 9, 2017
@ayumi ayumi force-pushed the fix/url-bar-is-bookmarked branch from 754765b to 7893edb May 9, 2017
@bsclifton bsclifton added this to the 0.15.400 milestone May 9, 2017
@ayumi ayumi force-pushed the fix/url-bar-is-bookmarked branch from 7893edb to 197acd6 May 9, 2017
@ayumi ayumi changed the title Upgrade lru-cache and cache isSiteBookmarked() in nav bar In nav bar bookmarked star, check only the specific siteKey May 10, 2017
@ayumi
Copy link
Contributor Author

ayumi commented May 10, 2017

@bsclifton @darkdh hmm so this is almost good! except it doesn't work when you bookmark into a folder (because folderId is part of siteKey)
@ayumi
In nav bar bookmarked star, check only the specific siteKey
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
Loading status checks…
a92d7d5 
Rather than iterating over all sites.

Test Plan:
1. Make sure automated tests pass
@ayumi ayumi force-pushed the fix/url-bar-is-bookmarked branch from 197acd6 to a92d7d5 May 11, 2017
@bbondy bbondy modified the milestones: 0.15.300, 0.15.400 May 15, 2017
@NejcZdovc
Copy link
Member

NejcZdovc commented May 18, 2017

@ayumi what is the status on this one?
@ayumi
Copy link
Contributor Author

ayumi commented May 18, 2017

@NejcZdovc Just working on tests
@ayumi
Copy link
Contributor Author

ayumi commented May 19, 2017

@NejcZdovc closing in favor of #8894
@ayumi ayumi closed this May 19, 2017
@luixxiul luixxiul removed this from the 0.15.300 milestone May 19, 2017
@cezaraugusto cezaraugusto deleted the fix/url-bar-is-bookmarked branch Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ayumi ayumi

Labels
feature/URLbar perf
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@ayumi @NejcZdovc @bbondy @luixxiul @bsclifton
You can’t perform that action at this time.