Skip to content
This repository has been archived by the owner. It is now read-only.

block webgl2 fingerprinting and webgl readPixels #8781

Merged
merged 1 commit into from May 17, 2017
Merged

block webgl2 fingerprinting and webgl readPixels #8781

merged 1 commit into from May 17, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented May 9, 2017

fix #8448

Test Plan:

  1. go to https://browserleaks.com/webgl and turn on fingerprinting protection
  2. the report hash should be '0C21A6FA2A9BD79DFF6E128FE55094B4'
  3. the image hash should be empty
  4. all the fields under the triangle image should be empty
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
fix #8448

Test Plan:
1. go to browserleaks.com/webgl and turn on fingerprinting protection
2. the report hash should be '0C21A6FA2A9BD79DFF6E128FE55094B4'
3. the image hash should be empty
4. all the fields under the triangle image should be empty
@diracdeltas diracdeltas added this to the 0.15.400 milestone May 9, 2017
@diracdeltas diracdeltas self-assigned this May 9, 2017
@diracdeltas diracdeltas requested a review from bsclifton May 9, 2017
@diracdeltas
Copy link
Member Author

diracdeltas commented May 9, 2017

if you get a 'report hash' other than the value in the test plan, please copy and paste document.querySelector('#webgl-table').innerText. it's not a big deal if it is OS-dependent, but should be fixed if it leaks more information than is in the user-agent string.

@luixxiul luixxiul added the privacy label May 17, 2017
Copy link
Contributor

luixxiul left a comment

Test plan works. Confirmed the values become empty with this change. LGTM.

@luixxiul
Copy link
Contributor

luixxiul commented May 17, 2017

CC @bsclifton for confirmation

@diracdeltas
Copy link
Member Author

diracdeltas commented May 17, 2017

I think this should be moved into next release because any site could have been evading webgl fingerprinting blocking using the WebGL2RenderingContext API. This API was introduced in Chromium 56, so it's a somewhat recent regression.

@diracdeltas diracdeltas modified the milestones: 0.15.300, 0.15.400 May 17, 2017
Copy link
Member

bsclifton left a comment

++

@bsclifton bsclifton merged commit 3e7de4e into master May 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@bsclifton bsclifton deleted the fix/8448 branch May 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.