This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsaveAppState needs to be called to perform the quit #8830
Merged
+1
−0
Conversation
… from the lastWindowClosed case) Unintentionally introduced with 40abc0c#diff-2018087f584c4398b5c3a23fc0e5f9dbR172 True needs to be passed, because the last known window state is saved, so receivedAllWindows is always false Fixes #8629 Auditors: @bridiver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bsclifton commentedMay 11, 2017
saveAppState needs to be called to perform the quit
(was only missing from the lastWindowClosed case)
Unintentionally introduced with 40abc0c#diff-2018087f584c4398b5c3a23fc0e5f9dbR172
True needs to be passed, because the last known window state is saved, so receivedAllWindows is always false
Fixes #8629
Auditors: @bridiver
cc: @jonathansampson, @NejcZdovc
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests