Skip to content
This repository has been archived by the owner. It is now read-only.

saveAppState needs to be called to perform the quit #8830

Merged
merged 1 commit into from May 11, 2017

Conversation

@bsclifton
Copy link
Member

bsclifton commented May 11, 2017

saveAppState needs to be called to perform the quit
(was only missing from the lastWindowClosed case)

Unintentionally introduced with 40abc0c#diff-2018087f584c4398b5c3a23fc0e5f9dbR172
True needs to be passed, because the last known window state is saved, so receivedAllWindows is always false

Fixes #8629

Auditors: @bridiver
cc: @jonathansampson, @NejcZdovc

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run indivually or as a suite ref
… from the lastWindowClosed case)

Unintentionally introduced with 40abc0c#diff-2018087f584c4398b5c3a23fc0e5f9dbR172
True needs to be passed, because the last known window state is saved, so receivedAllWindows is always false

Fixes #8629

Auditors: @bridiver
@bsclifton bsclifton added this to the 0.15.300 milestone May 11, 2017
@bsclifton bsclifton self-assigned this May 11, 2017
@bsclifton bsclifton requested review from bridiver and NejcZdovc May 11, 2017
@bsclifton bsclifton merged commit 12199f9 into master May 11, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bsclifton bsclifton deleted the fix-zombie-processes branch May 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.