This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAutoplay refactor #8848
Merged
Autoplay refactor #8848
Conversation
|
working on test |
1. Move autoplay to site settings 2. Introduce built-in site settings fix #8847 Auditors: @bbondy, @bsclifton Test Plan: Covered by webdriver test and unit test
|
Please provide built-in site settings list to support |
| tab.on('destroyed', function temporaryAllow (e) { | ||
| if (!persist) { | ||
| appActions.removeSiteSetting(origin, 'autoplay') | ||
| // tab.removeListener('did-finish-load', temporaryAllow) |
This comment has been minimized.
This comment has been minimized.
|
++ |
This was referenced May 15, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
darkdh commentedMay 12, 2017
•
edited
fix #8847
Auditors: @bbondy, @bsclifton
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Covered by webdriver test and unit test
Reviewer Checklist:
Tests