Skip to content
This repository has been archived by the owner. It is now read-only.

Autoplay refactor #8848

Merged
merged 1 commit into from May 15, 2017
Merged

Autoplay refactor #8848

merged 1 commit into from May 15, 2017

Conversation

@darkdh
Copy link
Member

darkdh commented May 12, 2017

  1. Move autoplay to site settings
  2. Introduce built-in site settings

fix #8847

Auditors: @bbondy, @bsclifton

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:
Covered by webdriver test and unit test

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run indivually or as a suite ref
@darkdh darkdh self-assigned this May 12, 2017
@darkdh
Copy link
Member Author

darkdh commented May 12, 2017

working on test

1. Move autoplay to site settings
2. Introduce built-in site settings

fix #8847

Auditors: @bbondy, @bsclifton

Test Plan:
Covered by webdriver test and unit test
@darkdh darkdh force-pushed the autoplay_refactor branch from 600a3a3 to 1dc8459 May 12, 2017
@darkdh darkdh changed the title [WIP] Move autoplay to site setting Autoplay refactor May 12, 2017
@darkdh darkdh requested review from bsclifton and bbondy May 12, 2017
@darkdh
Copy link
Member Author

darkdh commented May 12, 2017

Please provide built-in site settings list to support js/data/siteSettingsList.js

@darkdh darkdh added this to the 0.15.300 milestone May 12, 2017
tab.on('destroyed', function temporaryAllow (e) {
if (!persist) {
appActions.removeSiteSetting(origin, 'autoplay')
// tab.removeListener('did-finish-load', temporaryAllow)

This comment has been minimized.

Copy link
@bbondy

bbondy May 15, 2017

Member

nit: pls remove this commented out code

@bbondy
Copy link
Member

bbondy commented May 15, 2017

++

@bbondy bbondy merged commit 6fc7092 into master May 15, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
darkdh added a commit that referenced this pull request May 15, 2017
Auditors: @bbondy
@bsclifton bsclifton deleted the autoplay_refactor branch May 15, 2017
This was referenced May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.