Skip to content
This repository has been archived by the owner. It is now read-only.

update urlbar value on selection change #8868

Merged
merged 1 commit into from May 15, 2017
Merged

update urlbar value on selection change #8868

merged 1 commit into from May 15, 2017

Conversation

@bridiver
Copy link
Collaborator

bridiver commented May 15, 2017

fix #8865

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
fix #8865
@bridiver bridiver requested review from jonathansampson and bbondy May 15, 2017
@bsclifton bsclifton added this to the 0.15.300 milestone May 15, 2017
@bbondy
Copy link
Member

bbondy commented May 15, 2017

There's still various navbar tests that are failing so not sure if this makes it worse or better for tests, but I verified it does fix the problem reported so merging.

@bbondy bbondy merged commit 1f25edb into master May 15, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
bbondy added a commit that referenced this pull request May 15, 2017
update urlbar value on selection change
Copy link
Collaborator

jonathansampson left a comment

Nice work!

@bsclifton bsclifton deleted the issue-8865 branch May 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.