Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Fixes lion badge when disabled #8893

Merged
merged 1 commit into from May 17, 2017
Merged

Fixes lion badge when disabled #8893

merged 1 commit into from May 17, 2017
+46 −3

Conversation

@NejcZdovc
Copy link
Member

NejcZdovc commented May 16, 2017 •
edited by bsclifton

Test Plan

  • Visit any site
  • Disable shields
  • Lion head is grayed out

Description

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Resolves #8889

Auditors: @bsclifton

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
@NejcZdovc NejcZdovc added this to the 0.15.300 milestone May 16, 2017
@NejcZdovc NejcZdovc self-assigned this May 16, 2017
@NejcZdovc
Fixes lion badge when disabled
Unverified
This user has not uploaded their public key yet.
GPG key ID: 584931E990AC6064 Learn about signing commits
Loading status checks…
b9e3b53 
Resolves #8889

Auditors: @bsclifton

Test Plan:
- Visit any site
- Disable shields
- Lion head is grayed out
@NejcZdovc NejcZdovc force-pushed the NejcZdovc:hotfix/#8889-lion branch from 379678a to b9e3b53 May 17, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton May 17, 2017
@luixxiul
luixxiul approved these changes May 17, 2017
View changes
Copy link
Contributor

luixxiul left a comment

Test plan works. the automated test works too.
@bsclifton
bsclifton approved these changes May 17, 2017
View changes
Copy link
Member

bsclifton left a comment

Works great 😄 Huge thanks for adding a test for this too! ❤️
@bsclifton bsclifton merged commit df7aea7 into brave:master May 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@srirambv srirambv mentioned this pull request May 17, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luixxiul luixxiul

@bsclifton bsclifton

Assignees

@NejcZdovc NejcZdovc

Labels
QA/test-plan-specified feature/shields regression release-notes/exclude
Projects
None yet
Milestone
  0.15.300 (Frozen,...
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@NejcZdovc @luixxiul @bsclifton
You can’t perform that action at this time.