This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix regression: privateTabPaddingHorizontal #8898
Merged
Conversation
Addresses #8895 Auditors: @cezaraugusto Test Plan: 1. new private tab paragraphs should be properly spaced
|
++! |
|
thanks but I think as we move more things to Aphrodite we should avoid using global styles for spacing and keep that file specific for future-friendly theming |
|
For the sake of that I have added the prefix privateTab to the var :-) |
|
I agree here with @cezaraugusto, because this will probably only used in private tab, we don't need it in global. We should keep global as slick as possible. |
|
My thought on ^: #8340 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


luixxiul commentedMay 17, 2017
•
edited
Addresses #8895
Auditors: @cezaraugusto
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests