Skip to content
This repository has been archived by the owner. It is now read-only.

Fix regression: privateTabPaddingHorizontal #8898

Merged
merged 1 commit into from May 17, 2017
Merged

Conversation

@luixxiul
Copy link
Contributor

luixxiul commented May 17, 2017

Addresses #8895

Auditors: @cezaraugusto

Test Plan:

  1. new private tab paragraphs should be properly spaced

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
Suguru Hirahara
Addresses #8895

Auditors: @cezaraugusto

Test Plan:
1. new private tab paragraphs should be properly spaced
@luixxiul luixxiul requested a review from cezaraugusto May 17, 2017
@luixxiul luixxiul self-assigned this May 17, 2017
@luixxiul luixxiul added this to the 0.15.300 milestone May 17, 2017
@bsclifton
Copy link
Member

bsclifton commented May 17, 2017

Here before
screen shot 2017-05-17 at 9 20 22 am

and after
screen shot 2017-05-17 at 9 28 55 am

Copy link
Member

bsclifton left a comment

++! 😄

@bsclifton bsclifton merged commit 58e3bcc into brave:master May 17, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@luixxiul luixxiul deleted the luixxiul:fix-paddingHorizontal branch May 17, 2017
@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 17, 2017

thanks but I think as we move more things to Aphrodite we should avoid using global styles for spacing and keep that file specific for future-friendly theming

@luixxiul
Copy link
Contributor Author

luixxiul commented May 17, 2017

For the sake of that I have added the prefix privateTab to the var :-)

@NejcZdovc
Copy link
Member

NejcZdovc commented May 17, 2017

I agree here with @cezaraugusto, because this will probably only used in private tab, we don't need it in global. We should keep global as slick as possible.

@luixxiul
Copy link
Contributor Author

luixxiul commented May 18, 2017

My thought on ^: #8340 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.