Skip to content
This repository has been archived by the owner. It is now read-only.

make number of tabs match max tabs per page #8971

Merged
merged 1 commit into from May 20, 2017
Merged

Conversation

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 20, 2017

Auditors: @bbondy, @bsclifton
Fix #8909

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

  1. Pin 3 tabs
  2. Open tabs until a new tab set opens
  3. Tab should focus on that new tab set
  4. The number of unpinned tabs before new tab set opens should be the same as specified in settings

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
Auditors: @bbondy, @bsclifton
Fix #8909
@cezaraugusto cezaraugusto requested review from bbondy and bsclifton May 20, 2017
@cezaraugusto cezaraugusto self-assigned this May 20, 2017
@cezaraugusto cezaraugusto added this to the 0.15.300 milestone May 20, 2017
@bbondy
Copy link
Member

bbondy commented May 20, 2017

💯 @cezaraugusto mentions he'll be writing a test for this here: #8972

@bbondy bbondy merged commit 531c171 into brave:master May 20, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
bbondy added a commit that referenced this pull request May 20, 2017
make number of tabs match max tabs per page
@bsclifton

This comment has been minimized.

Copy link
Member

bsclifton commented on 294750a May 20, 2017

++! 😄

@cezaraugusto cezaraugusto deleted the cezaraugusto:tabsbar/8909 branch Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.