Skip to content
This repository has been archived by the owner. It is now read-only.

Update tab bookmarked state #9003

Merged
merged 1 commit into from May 23, 2017
Merged

Update tab bookmarked state #9003

merged 1 commit into from May 23, 2017

Conversation

@ayumi
Copy link
Contributor

ayumi commented May 22, 2017

Fix #8977

Auditors: @bsclifton @bbondy

Test Plan:

  1. Open https://github.com
  2. Bookmark the page
  3. Click the middle mouse button to open it in a new tab and switch to the new tab quickly (before it finishes loading)
  4. Tab should have bookmark star icon

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
Fix #8977

Auditors: @bsclifton @bbondy

Test Plan:
1. Open https://github.com
2. Bookmark the page
3. Click the middle mouse button to open it in a new tab and switch to the new tab quickly (before it finishes loading)
4. Tab should have bookmark star icon
@ayumi ayumi requested a review from bsclifton May 22, 2017
Copy link
Member

bsclifton left a comment

Works great! Thanks 😄

@bsclifton bsclifton merged commit a8a6ef1 into master May 23, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@bsclifton bsclifton deleted the fix/bookmark-star-bg-tabs branch May 23, 2017
@luixxiul luixxiul added this to the 0.15.300 milestone May 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.