Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Avoid iterating all sites on every about page #9015

Merged
merged 1 commit into from May 24, 2017
Merged

Avoid iterating all sites on every about page #9015

merged 1 commit into from May 24, 2017
+22 −7

Conversation

@ayumi
Copy link
Contributor

ayumi commented May 23, 2017 •
edited

Fix #9004

With 10K bookmarks, saves 350 ms every new tab!

Auditors: @bsclifton

Test Plan:

  1. Check that tests pass.
  2. Bookmark a page
  3. Make a bookmark folder
  4. Open Bookmarks manager and confirm bookmark page and folder.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
@ayumi
Avoid iterating all sites on every about page
Verified
This commit was signed with a verified signature.
ayumi ａｙｕｍｉ  ｙｕ
GPG key ID: FFC29CB6ED2EC961 Learn about signing commits
Loading status checks…
fa5e987 
Fix #9004

Auditors: @bsclifton

Test Plan:
0. Check that tests pass.
1. Bookmark a page
2. Make a bookmark folder
3. Open Bookmarks manager and confirm bookmark page and folder.
@ayumi ayumi requested review from bbondy and bsclifton May 23, 2017
@ayumi ayumi self-assigned this May 23, 2017
@ayumi ayumi added this to the 0.15.300 milestone May 23, 2017
@bbondy
Copy link
Member

bbondy commented May 24, 2017

nice find 💯
@bbondy bbondy merged commit 6a9a017 into master May 24, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
bbondy added a commit that referenced this pull request May 24, 2017
@bbondy
Merge pull request #9015 from brave/fix/slow-about-pages
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: 52EE2E5BD38B6A2D Learn about signing commits
Loading status checks…
283f811 
Avoid iterating all sites on every about page
@ayumi ayumi mentioned this pull request May 24, 2017
Closed
bridiver added a commit that referenced this pull request May 24, 2017
@bbondy @bridiver
Merge pull request #9015 from brave/fix/slow-about-pages
7c5a329 
Avoid iterating all sites on every about page
@bsclifton
bsclifton reviewed May 24, 2017
View changes
Copy link
Member

bsclifton left a comment

++! 😄
@bsclifton bsclifton deleted the fix/slow-about-pages branch May 24, 2017
bridiver added a commit that referenced this pull request May 25, 2017
@bbondy @bridiver
Merge pull request #9015 from brave/fix/slow-about-pages
8beea37 
Avoid iterating all sites on every about page
bridiver added a commit that referenced this pull request May 25, 2017
@bbondy @bridiver
Merge pull request #9015 from brave/fix/slow-about-pages
f83125c 
Avoid iterating all sites on every about page
bridiver added a commit that referenced this pull request May 25, 2017
@bbondy @bridiver
Merge pull request #9015 from brave/fix/slow-about-pages
113c255 
Avoid iterating all sites on every about page
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton

@bbondy bbondy

Assignees

@ayumi ayumi

Labels
feature/about-pages perf
Projects
None yet
Milestone
  0.15.300 (Frozen,...
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@ayumi @bbondy @bsclifton @luixxiul
You can’t perform that action at this time.